Skip to content

Conversation

@hfxsd
Copy link
Collaborator

@hfxsd hfxsd commented Sep 2, 2025

What is changed, added or deleted? (Required)

Introduced a new 'global-indexes.md' document detailing global indexes, their use cases, limitations, and implementation. Updated references and links across multiple files to point to the new documentation, replacing inlined or outdated content. Removed the inlined global index section from 'partitioned-table.md' and adjusted related documentation and best practices to reference the new page. Added supporting images for global index mechanisms and comparisons.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Introduced a new 'global-indexes.md' document detailing global indexes, their use cases, limitations, and implementation. Updated references and links across multiple files to point to the new documentation, replacing inlined or outdated content. Removed the inlined global index section from 'partitioned-table.md' and adjusted related documentation and best practices to reference the new page. Added supporting images for global index mechanisms and comparisons.
@hfxsd hfxsd self-assigned this Sep 2, 2025
@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 2, 2025
@hfxsd hfxsd added translation/doing This PR’s assignee is translating this PR. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. and removed contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 2, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 2, 2025

@Defined2014: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 2, 2025
Expanded the summary in global-indexes.md to include TiDB global index scenarios, advantages, usage, implementation, and limitations. The new summary highlights performance improvements, simplified development, management methods, and a comparison with local indexes, as well as performance data and technical details.
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 4, 2025

@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hfxsd hfxsd requested a review from lilin90 September 11, 2025 05:36
@lilin90 lilin90 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Nov 25, 2025
@lilin90 lilin90 added the requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. label Dec 1, 2025
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 4, 2025

@lilin90: Your lgtm message is repeated, so it is ignored.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lilin90 lilin90 added the type/enhancement The issue or PR belongs to an enhancement. label Dec 4, 2025
@lilin90
Copy link
Member

lilin90 commented Dec 4, 2025

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 4, 2025
@lilin90 lilin90 added the lgtm label Dec 4, 2025
@ti-chi-bot ti-chi-bot bot merged commit c9c2c4e into pingcap:master Dec 4, 2025
6 of 7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #21169.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Dec 4, 2025
@lilin90
Copy link
Member

lilin90 commented Dec 4, 2025

A format issue introduced in this PR caused build failure, which is fixed in #21170.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. requires-version-specific-changes After cherry-picked, the cherry-picked PR requires further changes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants