auto-calculate --users from --requests_per_sec to target QPS is achieved#343
Merged
ajit-vijayakumar merged 1 commit intomainfrom Mar 4, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
--requests_per_secis set but--usersis left at its default of 1, the benchmark often can't achieve the target QPS. Each user issues requests sequentially, so a single user's max throughput is bounded by request latency (1 / latency). Users have to manually calculate and set--usersto work around this, which is error-prone.Solution
Auto-calculate
--usersfrom--requests_per_secwhen not explicitly provided. Assuming a conservative 500ms request latency, each user can do ~2 req/s, so we provisionceil(qps * 0.5)users. Explicit--usersstill overrides the calculation. When--requests_per_secis not set (unlimited), defaults to 1 user as before.Type of Change
Test Plan
--requests_per_sec=100and no--users: startup log showsusers=50--requests_per_secand no--users: startup log showsusers=1(backward compat)--requests_per_sec=100 --users=10: startup log showsusers=10(explicit override)--requests_per_sec=1and no--users: startup log showsusers=1(low QPS edge case)