add english audio from festival

[moshe742]

I added another English voice since the voice included in the
repository is with accent and I think the voice I created is better for others.

I did it by adding a folder with the recordings of voice from a program named
Festival which is open source text to speach software, any sound file which is not
a recording I copied from the original folder.

I checked the license for the Festival program and I can use it for any purpose,
both commercial and non-commercial, so I license it apache-2.0.

To use the added folder as the audio for the buds one can use the instructions
from the readme, so one should just build with the AUDIO environment variable
set to en_festival like so- AUDIO=en_festival ./build.sh

[shymega]

What is the purpose of this MR? We also need .license files for each audio clip, as per the REUSE spec.

Commits are just one big diff, and there is no PR description. We cannot merge it at this time.

[moshe742]

Thanks for the feedback.

The purpose is to improve (at least in my opinion) the accent of the English voice, done with festival.
I just added the directory and files so people can use it if they want to.

I didn't see any reuse spec, can you point it to me so I won't do this again.

I just rechecked about the license and it can be used for both commercial and non-commercial use with no restrictions, so should I choose a relevant license?

[moshe742]

Updated the PR with a better commit message and added the license as requested

[shymega]

Please remove the merge commits. PRs should never have merge commits when going into main. Instead, read-up on Git rebasing.

[moshe742]

Thanks for the feedback, removed the merge commits and did a rebase as asked

[shymega]

Thanks. What you're missing is .license files as generated with reuse --fallback-dot-license for each blob - i.e, the audio files. The commit message wouldn't be enough for the REUSE spec.

[moshe742]

Thanks, I forgot to add the REUSE.toml as an alternative for the license file per blob file, is this acceptable? (added it now)

[shymega]

I have fixed it in my local branch, and added license files per blob. We don't want a REUSE.toml just yet, we need to wait until BES get back to Pine64.

However, the overwhelming consensus from other issues is that we're leaning towards Apache-2.0, and GPL-3.0 would conflict with that, but IANAL. I think it would, anyway.

If I can force-push my changes, I can get this reviewed. Are you happy for the license to be changed to Apache-2.0?

[moshe742]

I can live with it

[shymega]

Done. It's best to create .license files or add the SPDX headers in text form, so that we're not reliant on REUSE.toml.

I'll leave this up to the other maintainers to decide whenever to merge.