Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admin order note user check #134

Closed
wants to merge 2 commits into from
Closed

Conversation

valentin-
Copy link
Contributor

Currently an error occurs when the user in the note object is empty.

Pimcore\Model\User\AbstractUser::getById(): Argument #1 ($id) must be of type int, null given, called in /app/vendor/pimcore/ecommerce-framework-bundle/src/Controller/AdminOrderController.php on line 332

@dvesh3 dvesh3 changed the base branch from 1.0 to 1.x November 7, 2023 10:56
@dvesh3 dvesh3 added the Bug label Nov 7, 2023
@dvesh3 dvesh3 added this to the 1.0.6 milestone Nov 7, 2023
@dvesh3
Copy link
Contributor

dvesh3 commented Nov 7, 2023

This has some unrelated commits.

@valentin- valentin- closed this Nov 7, 2023
@valentin- valentin- deleted the 1.0 branch November 7, 2023 11:13
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants