fix: honor positional input in save commands#646
Open
4paulpak wants to merge 1 commit intopimalaya:masterfrom
Open
fix: honor positional input in save commands#6464paulpak wants to merge 1 commit intopimalaya:masterfrom
4paulpak wants to merge 1 commit intopimalaya:masterfrom
Conversation
7ab2e05 to
0fae935
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #645
This fixes non-interactive positional input handling for draft save commands.
Changes:
message savenow uses the positional message when it is provided, even when stdin is not a TTYtemplate savenow uses the positional template when it is provided, even when stdin is not a TTYtemplate saveno longer appends the same draft twiceRepro before:
message save ... $'Subject: ...\r\n\r\nBody'sentAPPEND Drafts {0}template save ... $'From: ...\n\nBody'failed withcannot parse templateVerified with patched binary against IMAP proxy:
message savenow sends a non-empty append (APPEND Drafts {71}in my repro)template savenow sends a non-empty append (APPEND Drafts {347}in my repro)