Upgrade actions CI workflow#361
Conversation
|
I know we sometimes disagree on what a 'trivial' change is, but this seems trivial enough to me to merge. But @blakeembrey requested reviews explicitly from three TC members. Was there some particular aspect of this that needs extra scrutiny? |
I thought the trivial was only for the 36 hour wait, but I was just going to always wait to avoid an accidental non-trivial merge. Since I am the only maintainer/captain I think the only approvals can come from another TC member. There isn't yet a TC reviewer tag so I just added a few people who might want to review it. No specific reason for 3 other than ensuring a review. Is there a preferred way to do this now? |
this is an annoying GH behavior. we need to add the TC team explicitly as collaborators on this repo with write access in order to be able to tag it for review |
|
I think someone, maybe @UlisesGascon?, started adding a |
|
@wesleytodd you may be thinking of the CPC concept |
|
Yeah same concept I think but I mean specifically like here: expressjs/express#6336 |
Current action is failing on
Missing download info for actions/cache@v2. There's some cache built into the newersetup-node, but the dependency caching doesn't make much difference for overall test perf to warrant trying to keep it in the workflow.