Eliminate interface-boxing allocations in blocks.go #228
+66
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
internal/lz4block/blocks.goincurs an allocation on every call toPut, even when the pool is already expanded, because putting. a[]byteinto aninterface{}requires a heap allocation of the slice header. We can avoid this by using array pointers without changing theGetandPutfunction signatures.This change does require Go 1.17 minimum. If this is an issue, I can make another version of this PR with build tags to conditionally use this new technique.
My first time contributing to this repo; open to any feedback!
Before 2nd commit on this branch:
After 2nd commit: