Complete workout generator acceptance functionality and enhance UI integration #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes the incomplete workout generator functionality by implementing the missing
acceptWorkout()method and enhancing the UI integration between workout generation and review components.Problem
The
WorkoutGeneratorViewModelhad a TODO comment in theacceptWorkout()method where workout parsing and persistence logic was missing:Additionally, the UI flow was incomplete - the workout generator showed raw JSON instead of a proper structured review interface.
Solution
1. Complete Workout Parsing Implementation
2. Enhanced UI Integration
WorkoutGeneratorReviewViewfor structured workout preview3. Workout Type Specialization
Each workout type now generates appropriate interval structures:
4. Comprehensive Testing
Files Changed
Dropped/ViewModels/WorkoutGeneratorViewModel.swift- Complete implementation of workout acceptanceDropped/Views/WorkoutGeneratorView.swift- Enhanced UI with review integrationDropped/Views/WorkoutGeneratorReviewView.swift- Safe parsing with fallback logicDroppedTests/WorkoutGeneratorViewModelTests.swift- Comprehensive unit testsDroppedTests/WorkoutGeneratorIntegrationTests.swift- End-to-end workflow testsdocs/memory.md- Updated documentationTesting
The implementation includes comprehensive tests covering:
WorkoutManagerfor persistenceResult
Users can now:
The workout generator now provides a complete, polished experience from AI generation to workout acceptance with proper data persistence and user-friendly interface.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.