Skip to content

Conversation

@picatz
Copy link
Owner

@picatz picatz commented Jul 7, 2025

This pull request introduces support for identifying google.golang.org/protobuf/proto.Message types as potential sources in taint analysis, particularly for gRPC-based services. It includes updates to the taint analysis logic, new helper functions, and additional test cases across multiple vulnerability categories like log injection and SQL injection.

Enhancements to taint analysis:

  • Added google.golang.org/protobuf/proto.Message as a source type in taint analysis for log injection and SQL injection vulnerabilities.
  • Updated checkSSAValue function to check if a type implements the ProtoMessage method, identifying protobuf message types as sources.
  • Introduced the hasProtoMessageMethod helper function to determine if a type implements the ProtoMessage method.

Miscellaneous updates:

  • Added go/types import to support type-checking logic for ProtoMessage method detection.

https://chatgpt.com/codex/tasks/task_e_686bf2bc49988331aedaf649cb8f59cd

@picatz picatz requested a review from Copilot July 7, 2025 16:41
@picatz picatz linked an issue Jul 7, 2025 that may be closed by this pull request

This comment was marked as resolved.

@picatz picatz merged commit 548eea1 into main Jul 7, 2025
1 check passed
@picatz picatz deleted the codex/extend-taint-analysis-for-grpc-requests branch July 7, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider adding gRPC specific tests

2 participants