Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
This PR combines a few small changes I have distilled from user reports across Discourse over the past week, sorry for not putting them in separate PRs but they are rather small on their own.
List of changes:
compile_filter_regex()
should match case-insensitive (used bywebserver.api.excludeDomains
andwebserver.api.excludeClients
)files.setupVars
frompihole-FTL.toml
as this path does not need to be configurable. I hard-wired the (likewise hard-wired) pre-v6.0 pathdns.rateLimit.count
still referring to the old setting (RATE_LIMIT=1/3600
=>dns.rateLimit.count=1 and dns.rateLimit.interval=3600
)webserver.api.allow_destructive
mentioning the ability to shut down the system even though we don't offer this in v6.0get_web_port()
as the 32 bytes may be too limiting and the finalos
may be clippeddns.cache.upstreamBlockedTTL = 0
actually causes discarding of upstream blocked queriesbatchDelete
for lists and groupsRelated issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase
)Checklist:
developmental
branch.