Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* tests/timezones.phpt - added LC_ALL=C to prevent test failing when … #507

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

chrisbckr
Copy link
Contributor

…another locale is set as default

My LC is set to pt_BR.utf8/pt_BR, so the test always will fail without setting LC_ALL=C.

---- EXPECTED OUTPUT
Thu Mar 20 2014 11:03:24 GMT+0200 (Eastern European Standard Time)
Thu Mar 20 2014 05:03:24 GMT-0400 (Eastern Daylight Time)
Thu Mar 20 2014 11:03:24 GMT+0200 (Eastern European Standard Time)
===EOF===
---- ACTUAL OUTPUT
Thu Mar 20 2014 11:03:24 GMT+0200 (Horário Padrão da Europa Oriental)
Thu Mar 20 2014 05:03:24 GMT-0400 (Horário de Verão do Leste)
Thu Mar 20 2014 11:03:24 GMT+0200 (Horário Padrão da Europa Oriental)
===EOF===
---- FAILED

But in fact the test was a success. Setting LC_ALL=C will prevent this.

@stesie
Copy link
Member

stesie commented Feb 20, 2023

hmm, I wonder whether we should set this to C.UTF-8 like we already do in the Dockerfiles that run the tests automatically. Or at least used to do 🙈

But C should suffice so I don't mind.

Thanks for your contribution!

@stesie stesie merged commit 7515dde into phpv8:php8 Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants