Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segfault fix when using empty() #506

Merged
merged 2 commits into from
Feb 19, 2023
Merged

Segfault fix when using empty() #506

merged 2 commits into from
Feb 19, 2023

Conversation

redbullmarky
Copy link
Collaborator

@redbullmarky redbullmarky commented Feb 18, 2023

PHP8.0 changed cast_object so that it cannot be set to NULL.

Given that zend_get_std_object_handlers() provides a functional default, removing the code that assigns NULL to the cast_object handler resolves the issue.

closes #504

@stesie
Copy link
Member

stesie commented Feb 19, 2023

Hej Mark, thank you very much for tracking this down!

@stesie stesie merged commit eb61c4d into phpv8:php8 Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segmentation fault - possibly another GC issue?
2 participants