Remove supprt for V8 extensions, uncaught exceptions & V8Js::checkString method #484
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes support for V8 extensions, uncaught JS exceptions as well as the
V8Js::checkString
method, all of which have been marked as deprecated before.With snapshots there's a more flexible alternative available. On the other hand extensions always conflicted with PHP's request lifecycle.
Suppressing uncaught JS exceptions always felt a bit strange, especially since it was possible for sub-sequent exceptions to occur, that then overrode the former ones. Better wrap your
executeString
calls intry/catch
constructs -- and if you really need to, ignore the error there.V8Js::checkString
has been removed in favour ofV8Js::compileString
(which does effectively the same, except for not throwing away the compilation result).And this way the
V8Js
constructor looks way cleaner, especially when you just want to provide a snapshot 🎉Last chance to convince me, that this is a bad idea :-)