Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove supprt for V8 extensions, uncaught exceptions & V8Js::checkString method #484

Merged
merged 3 commits into from
Jun 27, 2022

Conversation

stesie
Copy link
Member

@stesie stesie commented May 31, 2022

This removes support for V8 extensions, uncaught JS exceptions as well as the V8Js::checkString method, all of which have been marked as deprecated before.

With snapshots there's a more flexible alternative available. On the other hand extensions always conflicted with PHP's request lifecycle.

Suppressing uncaught JS exceptions always felt a bit strange, especially since it was possible for sub-sequent exceptions to occur, that then overrode the former ones. Better wrap your executeString calls in try/catch constructs -- and if you really need to, ignore the error there.

V8Js::checkString has been removed in favour of V8Js::compileString (which does effectively the same, except for not throwing away the compilation result).

And this way the V8Js constructor looks way cleaner, especially when you just want to provide a snapshot 🎉

Last chance to convince me, that this is a bad idea :-)

@stesie stesie merged commit 461230b into phpv8:php8 Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant