Skip to content

Commit

Permalink
use isolate version of v8::ScriptOrigin
Browse files Browse the repository at this point in the history
  • Loading branch information
stesie committed May 31, 2022
1 parent 4327b4a commit d82d08f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion v8js_class.cc
Original file line number Diff line number Diff line change
Expand Up @@ -636,7 +636,7 @@ static void v8js_compile_script(zval *this_ptr, const zend_string *str, const ze
v8::Local<v8::String> sname = identifier
? V8JS_ZSTR(identifier)
: V8JS_SYM("V8Js::compileString()");
v8::ScriptOrigin origin(sname);
v8::ScriptOrigin origin(isolate, sname);

if (ZSTR_LEN(str) > std::numeric_limits<int>::max()) {
zend_throw_exception(php_ce_v8js_exception,
Expand Down
2 changes: 1 addition & 1 deletion v8js_methods.cc
Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,7 @@ V8JS_METHOD(require)

// Set script identifier
v8::Local<v8::String> sname = V8JS_STR(normalised_module_id);
v8::ScriptOrigin origin(sname);
v8::ScriptOrigin origin(isolate, sname);

if (Z_STRLEN(module_code) > std::numeric_limits<int>::max()) {
zend_throw_exception(php_ce_v8js_exception,
Expand Down

0 comments on commit d82d08f

Please sign in to comment.