Skip to content

Remove some AMQP stubs for functionMap #4217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2025

Conversation

VincentLanglet
Copy link
Contributor

@VincentLanglet VincentLanglet commented Aug 8, 2025

Same idea than #4185
I checked the signature one by one.

More could be removed when PHPStorm will be fixed
JetBrains/phpstorm-stubs#1775

The only change in reflection golden tests is

PHPStan\Reflection\ReflectionProviderGoldenTest::test with data set "METHOD AMQPExchange::delete" ('METHOD AMQPExchange::delete', 'Is built-in: Yes\nHas side-ef... mixed')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
 Visibility: public
 Variants: 1
     /**
-     * @param string $exchangeName
+     * @param string|null $exchangeName
      * @param int $flags
      * @return void
      */
     function delete(mixed $exchangeName = null, mixed $flags = 0): mixed'

/home/runner/work/phpstan-src/phpstan-src/tests/PHPStan/Reflection/ReflectionProviderGoldenTest.php:73

Which seems legit when looking at
https://github.com/php-amqp/php-amqp/blob/3618db5f781aa3d371b630c666bc90845d7c77d4/stubs/AMQPExchange.php#L114

@VincentLanglet VincentLanglet changed the title Remove som AMQP stubs for functionMap Remove some AMQP stubs for functionMap Aug 8, 2025
@ondrejmirtes ondrejmirtes merged commit 0ecdd06 into phpstan:2.1.x Aug 8, 2025
447 of 452 checks passed
@ondrejmirtes
Copy link
Member

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants