Skip to content

Added regression test #4216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2025
Merged

Added regression test #4216

merged 1 commit into from
Aug 8, 2025

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Aug 8, 2025

@staabm staabm marked this pull request as ready for review August 8, 2025 10:11
@phpstan-bot
Copy link
Collaborator

This pull request has been marked as ready for review.

@ondrejmirtes
Copy link
Member

Have you checked that this is slow on 2.1.18? Thanks.

@ondrejmirtes
Copy link
Member

I guess this has also been slower after your "unset" PR and faster again after 56a30c2

@staabm
Copy link
Contributor Author

staabm commented Aug 8, 2025

this PR:

➜  phpstan-src git:(b13310) hyperfine 'php vendor/bin/phpunit tests/PHPStan/Analyser/AnalyserIntegrationTest.php --filter testBug13310'
Benchmark 1: php vendor/bin/phpunit tests/PHPStan/Analyser/AnalyserIntegrationTest.php --filter testBug13310
  Time (mean ± σ):      1.373 s ±  0.017 s    [User: 1.212 s, System: 0.153 s]
  Range (min … max):    1.348 s …  1.407 s    10 runs

this PR with 56a30c2 reverted

  • I had to cancel the process after 60 seconds

@ondrejmirtes ondrejmirtes merged commit 48339e2 into phpstan:2.1.x Aug 8, 2025
276 checks passed
@ondrejmirtes
Copy link
Member

Thank you!

@staabm staabm deleted the b13310 branch August 8, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stuck process when modifyind array in foreach
3 participants