ArrayColumnHelper: Extract new getReturnValueType() method

phpstan · Jan 16, 2025 · 44ac0f2 · 44ac0f2
1 parent eacba20
commit 44ac0f2
Showing 1 changed file with 14 additions and 2 deletions.
diff --git a/src/Type/Php/ArrayColumnHelper.php b/src/Type/Php/ArrayColumnHelper.php
@@ -26,11 +26,14 @@ public function __construct(
 	{
 	}
 
-	public function handleAnyArray(Type $arrayType, Type $columnType, ?Type $indexType, Scope $scope): Type
+	/**
+	 * @return array{Type, TrinaryLogic}
+	 */
+	public function getReturnValueType(Type $arrayType, Type $columnType, Scope $scope): array
 	{
 		$iterableAtLeastOnce = $arrayType->isIterableAtLeastOnce();
 		if ($iterableAtLeastOnce->no()) {
-			return new ConstantArrayType([], []);
+			return [new NeverType(), $iterableAtLeastOnce];
 		}
 
 		$iterableValueType = $arrayType->getIterableValueType();
@@ -44,11 +47,20 @@ public function handleAnyArray(Type $arrayType, Type $columnType, ?Type $indexTy
 			}
 		}
 
+		return [$returnValueType, $iterableAtLeastOnce];
+	}
+
+	public function handleAnyArray(Type $arrayType, Type $columnType, ?Type $indexType, Scope $scope): Type
+	{
+		[$returnValueType, $iterableAtLeastOnce] = $this->getReturnValueType($arrayType, $columnType, $scope);
+
 		if ($returnValueType instanceof NeverType) {
 			return new ConstantArrayType([], []);
 		}
 
 		if ($indexType !== null) {
+			$iterableValueType = $arrayType->getIterableValueType();
+
 			$type = $this->getOffsetOrProperty($iterableValueType, $indexType, $scope, false);
 			if ($type !== null) {
 				$returnKeyType = $type;