Skip to content

Implement a filter that filters for Global IPs as per RFC 6890 #7893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

vnsavage
Copy link
Contributor

@vnsavage vnsavage commented Jan 6, 2022

This pull request is addressing the feature request for bug #77221 which in turn was a result of a bug report: #77217

@MaxSem
Copy link
Contributor

MaxSem commented Jan 8, 2022

This PR changes the values of publicly declared constants, and while this may seem like no big deal for these particular constants, better avoid it unless absolutely necessary. Also, needs tests.

@vnsavage
Copy link
Contributor Author

vnsavage commented Jan 9, 2022

Thanks for looking into it - I added tests as per your request. As for the constant - in this case it seems cleaner and safer to update the constants, because otherwise they will either overlap with conflicting flags (e.g. FILTER_REQUIRE_ARRAY - which is not entirely obvious from the .h file) or will be largely out of order ( e.g. after 0x0800000 we'll have 0x40000000 which will be the only instance of that in the file ).

@bukka
Copy link
Member

bukka commented Jul 18, 2022

I actually updated the constant as it's better to have higher value than change existing ones. It's merged via d8fc05c

@bukka bukka closed this Jul 18, 2022
@bukka
Copy link
Member

bukka commented Jul 18, 2022

Thanks for the contribution of this feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants