ext/soap: Refactor to_zval_bool() #18696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Girgias
commented
May 29, 2025
Girgias
commented
- Early return style
- Improve logic to get rid of unnecessary comparisons and calls to stricmp()
- Do not use convert_to_boolean API
- Early return style - Improve logic to get rid of unnecessary comparisons and calls to stricmp() - Do not use convert_to_boolean API
nielsdos
requested changes
May 29, 2025
nielsdos
requested changes
May 29, 2025
I blame copy paste
nielsdos
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.