ext/pgsql: Stop using useless convert_to_boolean() API #18683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
reviewed
May 28, 2025
ext/pgsql/pgsql.c
Outdated
| break; | ||
| case PHP_PG_ASYNC_REQUEST_CANCEL: { | ||
| PGcancel *c; | ||
| char err[256]; | ||
| int rc; | ||
|
|
||
| c = PQgetCancel(pgsql); | ||
| RETVAL_LONG((rc = PQcancel(c, err, sizeof(err)))); | ||
| rc = PQcancel(c, err, sizeof(err); |
There was a problem hiding this comment.
once you fixed this little typo, I ll have a better look ; seems ok at first glance.
There was a problem hiding this comment.
Seems like we should not be using PQCancel any longer? https://www.postgresql.org/docs/current/libpq-cancel.html#LIBPQ-PQCANCEL
Also it can only ever return 0 or 1, so the rc < 0 check is... wrong
devnexen
reviewed
May 28, 2025
devnexen
reviewed
May 28, 2025
devnexen
reviewed
May 29, 2025
There are better ways of handling this than casting the zval in place
Girgias
force-pushed
the
pgsql-convert-bool
branch
from
872e404 to
e3ea426
Compare
devnexen
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are better ways of handling this than casting the zval in place