Fix GH-18579: --libdir option default value #18596
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using PHP_LIBDIR for lib64 case Fix AS_CASE for libdir and datadir broken by quotes
|
Notice: applied in Fedora, it allows to build embed SAPI from the same tree than fpm (so reducing global build time) |
|
@petk as you are one of the few playing with build system, can you please review this one ? |
|
I think that's good, yes. I'll have to retest this a bit to refresh myself about this. Yes, I think it's about time that these installation directories get refactored, even if it is a BC break. So, for master (upcoming PHP 8.5) that's ideal timing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using PHP_LIBDIR for lib64 case
Fix AS_CASE for libdir and datadir broken by quotes
Only to master to avoid file placement in stable release
in some build, FPM status page will move from
/usr/share/fpmto/usr/share/php/fpmP.S. it seems the quote are there since always (at least in 5.6.0)