docs: add macos instruction, update blocks, misc changes #17642
Conversation
| # ------------------------------------------------------------------------------ | ||
| # Intellij IDEA configuration directory | ||
| # ------------------------------------------------------------------------------ | ||
| /.idea |
There was a problem hiding this comment.
This belongs in your personal gitignore.
There was a problem hiding this comment.
I like how people do various smart functions and then say it's not needed now.
I have a project with commited .idea folder, I cannot mark it globally ignored.
Otherwise one line is not a problem for any project.
Moreover there are about 300 lines with long comments.
And one more thing is gitignore already has definitions for some tools like this:
# Backup copies created by various editors or development tools
*~
vim? IDEA doesn't create such files
There was a problem hiding this comment.
It's not a problem to remove it and keep .idea changes separately from current changes, but it's not convenient as for me
There was a problem hiding this comment.
I have a project with commited .idea folder, I cannot mark it globally ignored.
You can use git add -f .idea if you want to add a file that's globally ignored.
There was a problem hiding this comment.
Also, you do have the option to ignore it locally, for only the current .git repo, by adding it to .git/info/exclude.
There was a problem hiding this comment.
I don't mind adding IDEs to the exclude file, but we should add all common ones then. At least .vscode, possibly Visual Studio (not sure what files it creates). Newer ones include .zed and .fleet, although they are more conservative about creating these directories (only on-demand).
There was a problem hiding this comment.
Yeah I got
.idea/
.vscode/
so might make sense to add those. Should be probably a different PR as we shouldn't mix unrelated things together.
There was a problem hiding this comment.
Do I need to create a separate PR with editing .gitignore file only?
There was a problem hiding this comment.
I don't object to this, but let's add all of the common IDEs (under the same header comment). Yes, preferably in a separate PR.
There was a problem hiding this comment.
Moved gitignore changes into the separate PR: #18669
README.md
Outdated
| Use `TESTS` variable to tests only specific directories: | ||
|
|
||
| ```shell | ||
| make TESTS=Zend/tests/throw/ test |
There was a problem hiding this comment.
You can also use TEST_PHP_ARGS for that. TEST_PHP_ARGS is an env variable while TESTS is passed as a shell argument. I'm not sure why both of these exist. Maybe @petk knows.
| On MacOS, you can install these using: | ||
|
|
||
| ```shell | ||
| brew install autoconf bison re2c iconv libxml2 sqlite |
There was a problem hiding this comment.
I wouldn't assume Homebrew; I'm using MacPorts instead and most instructions I see that mention brew packages will also mention the MacPorts equivalent.
There was a problem hiding this comment.
If you know the equivalent for MacPort instruction I'll add it
There was a problem hiding this comment.
That should resemble something like this
sudo port install autoconf bison re2c libiconv libxml2 sqlite3
README.md
Outdated
| make -j4 | ||
| On Unix system: | ||
| ```shell | ||
| make -j$(nproc) |
There was a problem hiding this comment.
nproc isn't also always available on every Unix; macOS doesn't include it and if you install GNU coreutils from MacPorts, that'll make it available prefixed as nproc. We should probably mention the other methods that David mentions or just use a simple -j4 for everyone (and tell people to adjust.)
|
Is there any changes I can make to push the PR further? |
|
Removing myself as reviewer as I don't use macOS normally, someone else should re-review this. |
No description provided.