[ext-curl] Add \CURLOPT_INFILESIZE_LARGE

[OskarStark]

This is my first PR on this repository and is based on:

• https://github.com/symfony/symfony/pull/59654/files#r1935358570

See https://github.com/curl/curl/blob/b13e9066b3dfd65ba8aadc336232ae7832ac687a/include/curl/curl.h#L1541

So feel free to close it :-)

[devnexen]

Two other things:

1/ you very likely edited curl_arginfo.h manually, I would suggest to revert this change locally and using build/gen_stub.php instead, i.e. php build/gen_stub.php ext/curl/curl.stub.php.
2/ Someone will very likely ask you to add a test before committing your change (i.e. ext/curl/tests for how they are made).

[OskarStark]

1/ you very likely edited curl_arginfo.h manually, I would suggest to revert this change locally and using build/gen_stub.php instead, i.e. php build/gen_stub.php ext/curl/curl.stub.php.

done, thanks

[arnaud-lb]

The existence of two distinct options CURLOPT_INFILESIZE and CURLOPT_INFILESIZE_LARGE is mostly due to low-level C considerations and I'm wondering if this distinction is useful/necessary in PHP. Are there cases where using CURLOPT_INFILESIZE_LARGE instead of CURLOPT_INFILESIZE would not behave as expected? Otherwise, should we define CURLOPT_INFILESIZE to @cvalue CURLOPT_INFILESIZE_LARGE directly?

[OskarStark]

I cannot answer this question, but maybe @nicolas-grekas can, but in the linked PR, we need to behave differently yes

[arnaud-lb]

I'm seeing just now that we already expose other _LARGE constants, so my suggestion would create inconsistencies. Therefore it's probably better to just add CURLOPT_INFILESIZE_LARGE as you are suggesting.

[TimWolla]

FWIW: The title of the PR typoed the name of the constant, the same issue also exists in the commit message, so probably be careful when merging this.

[OskarStark]

Hi @TimWolla can you explain? I can't see the typo

[devnexen]

he meant this

Add \CURLOPT_IN I FILESIZE_LARGE
...

you can amend this commit at some point, or the committer will take care of it no worries :)

[OskarStark]

Will do