Revert to httpbin org #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-demb
commented
Aug 7, 2024
| @@ -6,6 +6,10 @@ All notable changes to this project will be documented in this file. | |||
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | |||
|
|
|||
| ## [3.1.1] - 2024-xx-xx | |||
There was a problem hiding this comment.
please fill this information on a release moment
|
/cc @dbu |
andrew-demb
pushed a commit
to andrew-demb/socket-client
that referenced
this pull request
Aug 7, 2024
TO BE REVERTED after [1] AND need to update min version for the tests package [1] php-http/client-integration-tests#60
andrew-demb
added a commit
to andrew-demb/socket-client
that referenced
this pull request
Aug 7, 2024
TO BE REVERTED after [1] AND need to update min version for the tests package [1] php-http/client-integration-tests#60
2 tasks
dbu
approved these changes
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Switched from
https://httpbingo.orgin favor ofhttps://httpbin.org(revert of #56 + switching to https)The original problem with the upstream service was resolved: postmanlabs/httpbin#617
Why?
Service
https://httpbingo.orgreturns402 Payment Requiredstatus code for requests with no user agent (use-case ofphp-http/php-socket-client).Using this service with such side effects makes it harder to know what is wrong with some specific HTTP client adapter when tests failed just in one day (when upstream changed its rules).
Let's do it if we can switch to another service without such a strange behavior.
Checklist