Support configuring version per profile #123
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Apr 25, 2025
josevalim
reviewed
Apr 25, 2025
lib/tailwind.ex
Outdated
| @@ -163,8 +183,8 @@ defmodule Tailwind do | |||
| Returns `{:ok, version_string}` on success or `:error` when the executable | |||
| is not available. | |||
| """ | |||
| def bin_version do | |||
| path = bin_path() | |||
| def bin_version(profile \\ :default) do | |||
There was a problem hiding this comment.
Are you required to have a default profile? I don't think so... so this will likely be a breaking change in practice.
There was a problem hiding this comment.
If you do not have a default profile, this will now resolve to the path for the version configured 'globally' (aka configured_version/0), so that shouldn't be a breaking change.
The only "problem" is that after updating, people will have to rerun mix tailwind.install, because the path to the binary has changed to include the version string.
josevalim
reviewed
Apr 25, 2025
josevalim
reviewed
Apr 25, 2025
josevalim
reviewed
Apr 25, 2025
josevalim
reviewed
Apr 25, 2025
josevalim
reviewed
Apr 25, 2025
josevalim
reviewed
Apr 25, 2025
josevalim
reviewed
Apr 25, 2025
Co-authored-by: José Valim <[email protected]>
Co-authored-by: José Valim <[email protected]>
The `--if-missing` argument causes this test to be flaky. Previously, when you had downloaded another version, the newer version would automatically be missing and thus always be installed. Currently, that's no longer the case, because you can have multiple simultanous tailwind installs, so in this case (after the first test run), the newer version already exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our project, we had a place where we were running multiple builds through multiple tailwind profiles, and one had already been updated to be compatible with v4 (and thus incompatible with v3), while the other is still stuck on v3 for now.
I added support to run a different version of the CLI for a profile. If no version is explicitly configured for the profile, it will fall back to the globally configured tailwind version.
This should be a backwards-compatible (aka non-breaking) change.