Skip to content

fix: provide clear error when importing VerifiedRoutes instead of using #6638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dl-alexandre wants to merge 5 commits into
base: main
Choose a base branch
from
+13 −1
Open

fix: provide clear error when importing VerifiedRoutes instead of using #6638

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ca9324e
fix(phx.new): validate paths with colons before generating
dl-alexandre Mar 22, 2026
05fb33f
fix(installer): handle paths with colons defensively in expand_path_w…
dl-alexandre Mar 23, 2026
9abd82c
fix: provide clear error when importing VerifiedRoutes instead of using
dl-alexandre Mar 24, 2026
5088ab1
Apply suggestion from @josevalim
josevalim May 6, 2026
c9002b6
Apply suggestions from code review
josevalim May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions installer/lib/phx_new/project.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ defmodule Phx.New.Project do
def new(project_path, opts) do
project_path = Path.expand(project_path)
app = opts[:app] || Path.basename(project_path)

Comment thread
josevalim marked this conversation as resolved.
Outdated
app_mod = Module.concat([opts[:module] || Macro.camelize(app)])

%Project{
Expand Down
12 changes: 12 additions & 0 deletions lib/phoenix/verified_routes.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -927,6 +927,18 @@ defmodule Phoenix.VerifiedRoutes do
defp build_route(route_ast, sigil_p, env, endpoint_ctx, router) do
config = Module.get_attribute(env.module, :phoenix_verified_config, [])

if config == [] do
Comment thread
josevalim marked this conversation as resolved.
Outdated
raise ArgumentError, """
attempted to use Phoenix.VerifiedRoutes without calling `use Phoenix.VerifiedRoutes` first.

You must use `use Phoenix.VerifiedRoutes` with the appropriate options instead of importing it:

use Phoenix.VerifiedRoutes, endpoint: MyAppWeb.Endpoint, router: MyAppWeb.Router

See the documentation for more details on configuration options.
"""
end

router =
case Macro.expand(router, env) do
mod when is_atom(mod) ->
Expand Down