Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify logic to block deploys on PRs #22

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Simplify logic to block deploys on PRs #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d6f30c
tags will never be on a pull request
pho3nixf1re Dec 18, 2023
f188f39
docs(changeset): simplify logic to block deploys on PRs
pho3nixf1re Dec 18, 2023
9dba5f8
another attempt
pho3nixf1re Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/breezy-chicken-tickle.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"pho3nixf1re.net": patch
---

simplify logic to block deploys on PRs
4 changes: 1 addition & 3 deletions .github/workflows/build-and-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,7 @@ jobs:
path: ./out

deploy:
if:
github.event_name != 'pull_request' && startsWith(github.ref,
'refs/tags/v')
if: startsWith(github.ref,'refs/tags/v')
permissions:
contents: read
pages: write
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,15 @@ jobs:
name: Setup dependencies
runs-on: ubuntu-latest
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.PAT }}
steps:
- name: Checkout Repo
uses: actions/checkout@v4
with:
ssh-key: '${{ secrets.COMMIT_KEY }}'
token: ${{ secrets.PAT }}
- name: Configure git author
run: |
git config --unset http.https://github.com/.extraheader
git config --global user.name "github-actions[bot]"
git config --global user.email "41898282+github-actions[bot]@users.noreply.github.com"
- name: Setup Node.js
Expand Down