fix: prefer serial no over serial text #410
Conversation
The current serial based matching behaviour was specified in d9b1953. The commit message specifies that matching on serial number should be preferred over constructing a text based fingerprint from timing information (which matches legacy behaviour of autorandr). However, the actual code has the conditional reversed however, which means that the new behaviour was never employed. This means the matching behaviour is still suffering from the previous issues like changing edid data when the same monitor switches interface etc (DP to HDMI for example) or the port on the gpu changes and now has different capabilities etc. This commit switches the conditional around, using serial no. if it is not zero, using the legacy serial_text if available and otherwise setting serial to None
|
Sounds reasonable, thanks. Let's see if someone else using this feature and following the repo complains 🤔 If not, then I think merging and seeing what happens is the best path forward. What's WIP? |
BronzeDeer
changed the title
Thank you for taking such a quick look! I just flagged the PR as WIP (Work in progress) as I am used to gitlab automatically putting a PR into draft mode when it contains WIP: or [WIP]. I put it into draft because I had not been able to test it before uploading (or atleast it was easier to override my nix config if it was a different revision in the same repo). This change fixed my case where I was using two monitors of the same modell which showed up with the same timing informations but ultimately could be differentiated by serial no. Since this is now tested sucessfully on my end I removed the "WIP" tag and consider it mergeable from my side |
Fixes #406
The current serial based matching behaviour was specified in d9b1953. The commit message specifies that matching on serial number should be preferred over constructing a text based fingerprint from timing information (which matches legacy behaviour of autorandr).
However, the actual code has the conditional reversed, which means that the new behaviour was never employed. This means the matching behaviour is still suffering from the previous issues like changing edid data when the same monitor switches interface etc (DP to HDMI for example) or the port on the gpu changes and now has different capabilities etc.
This commit switches the conditional around, using serial no. if it is not zero, using the legacy serial_text if available and otherwise setting serial to None