Implement moveTabToNextWindow#4168
Closed
gliptak wants to merge 2 commits intophilc:masterfrom
gliptak:nextwindow1
Closed
Implement moveTabToNextWindow#4168gliptak wants to merge 2 commits intophilc:masterfrom gliptak:nextwindow1
gliptak wants to merge 2 commits intophilc:masterfrom
gliptak:nextwindow1
Conversation
Signed-off-by: Gábor Lipták <gliptak@gmail.com>
Tested this PR and works well. But Is there a way that
|
Author
|
@nikinbaidar thank you for reviewing. first one seems to be a design decision. as for the second one, you ca use the existing @philc please review |
|
How did I miss |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gábor Lipták gliptak@gmail.com
Description
#2407