Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading component #31

Merged
merged 8 commits into from
Sep 25, 2024
Merged

Loading component #31

merged 8 commits into from
Sep 25, 2024

Conversation

pxp9
Copy link
Contributor

@pxp9 pxp9 commented Sep 25, 2024

No description provided.

phcurado
phcurado reviewed Sep 25, 2024
View reviewed changes
lib/daisy_ui_components/loading.ex Outdated Show resolved Hide resolved
daisy_ui_components_site/mix.exs Outdated Show resolved Hide resolved
lib/daisy_ui_components/loading.ex Outdated Show resolved Hide resolved
lib/daisy_ui_components/loading.ex Show resolved Hide resolved
@pxp9
Copy link
Contributor Author

pxp9 commented Sep 25, 2024 •
edited
Loading

Mix updated some dependencies while i was running mix setup , thats why mix.lock changed.

@pxp9 pxp9 marked this pull request as ready for review September 25, 2024 10:58
@pxp9 pxp9 requested a review from phcurado September 25, 2024 10:59
phcurado
phcurado reviewed Sep 25, 2024
View reviewed changes
Copy link
Owner

@phcurado phcurado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, added a comment. Than you 🙏

lib/daisy_ui_components/loading.ex Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Sep 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build de8cd9d08ad1e9971b5cc30a20b6603bf010685b-PR-31

Details

  • 0 of 25 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.9%) to 64.249%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/daisy_ui_components/loading.ex 0 25 0.0%
Totals Coverage Status
Change from base Build 4953c4e152480f90e7eb15699e6908353da1d9cc: -2.9%
Covered Lines: 372
Relevant Lines: 579
💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Sep 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build de8cd9d08ad1e9971b5cc30a20b6603bf010685b-PR-31

Details

  • 0 of 25 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.9%) to 64.249%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/daisy_ui_components/loading.ex 0 25 0.0%
Totals Coverage Status
Change from base Build 4953c4e152480f90e7eb15699e6908353da1d9cc: -2.9%
Covered Lines: 372
Relevant Lines: 579
💛 - Coveralls

@phcurado phcurado merged commit ad2207c into phcurado:main Sep 25, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phcurado phcurado phcurado approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pxp9 @coveralls @phcurado