Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use assert_html to fix test with attribute ordering changed #29

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

brewerx
Copy link
Contributor

@brewerx brewerx commented Aug 15, 2024

Only changed form_test.exs in this PR because that was the one failing with newer versions of Elixir/OTP but the same improvement can be applied to other tests.

Tested this fix with versions:

Copy link
Owner

@phcurado phcurado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brewerx thank you for the contribution, all good to me

@phcurado phcurado merged commit 6af69cf into phcurado:main Aug 16, 2024
2 checks passed
@brewerx brewerx deleted the assert_html_support branch August 16, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants