Add FEATURE_JIT_SIMD option #966

guillep · 2025-04-30T07:31:33Z

Make JIT SIMD optional with <option: #FEATURE_JIT_SIMD>
Add option FEATURE_JIT_SIMD to CMakeLists.txt
Add FEATURE_JIT_SIMD as a compile time option

- Make JIT SIMD optional with <option: #FEATURE_JIT_SIMD> - Add option FEATURE_JIT_SIMD to CMakeLists.txt - Add FEATURE_JIT_SIMD as a compile time option

guillep · 2025-04-30T07:32:39Z

CMakeLists.txt

+option(VERBOSE_BUILD			"Verbose Build"														OFF)
+option(FEATURE_FFI				"Enable FFI"														ON)
+option(FEATURE_THREADED_FFI		"Enable Threaded (running in another thread) FFI"					ON)
+option(FEATURE_MESSAGE_COUNT	"Enable the option to count messages, only valid for StackVM"		OFF)
+option(FEATURE_NETWORK			"Enable network and sockets"										ON)
+option(FEATURE_JIT_SIMD			"Use SIMD support in JIT compilation when available"				ON)
+option(FEATURE_LIB_SDL2			"Build SDL2 support"												ON)
+option(FEATURE_LIB_CAIRO		"Build Cairo support"												ON)
+option(FEATURE_LIB_FREETYPE2	"Build freetype2 support"											ON)
+option(FEATURE_LIB_GIT2			"Build LibGit2 support"												ON)
+option(FEATURE_LIB_PTHREADW32	"Windows only, link to win32 version of pthread"					OFF)
+option(GENERATE_VMMAKER			"If it generates the VMMaker image"									ON)
+option(GENERATE_SOURCES			"If it generates the C sources"										ON)
+option(ALWAYS_INTERACTIVE		"Be interactive by default"											OFF)
+option(BUILD_BUNDLE				"Builds a bundle with all dependencies"								ON)
+option(FEATURE_COMPILE_GNUISATION
+								"Use gcc gnu extensions to compile the VM"							ON)
+option(FEATURE_COMPILE_INLINE_MEMORY_ACCESSORS
+								"Use inline memory accessors instead of macros"						ON)
+option(PHARO_DEPENDENCIES_PREFER_DOWNLOAD_BINARIES
+								"Prefer downloading dependencies"									OFF)
+option(PHARO_VM_IN_WORKER_THREAD
+								"Run the VM in a thread different that the main"					ON)
+option(DEPENDENCIES_FORCE_BUILD
+								"Force build libraries"												OFF)
+option(BUILD_WITH_GRAPHVIZ
+								"Generate dependency graphs"										ON)
+option(VERSION_UPDATE_FROM_GIT
+								"Extract version information from git tags. Default to true. Follow vX.Y.Z-suffix" ON)


I formatted a bit this code, the actually important line is line 25 adding

FEATURE_JIT_SIMD

Did you formatted or unformatted the code 😆

guillep · 2025-04-30T07:33:19Z

CMakeLists.txt

-if (${FEATURE_COMPILE_INLINE_MEMORY_ACCESSORS})
-    add_compile_definitions(USE_INLINE_MEMORY_ACCESSORS=1)
-endif()
-


I cleaned a bit these compile time definitions to make them local to the VM library compilation and not global options to the entire project.

guillep · 2025-04-30T07:35:24Z

smalltalksrc/Melchor/VMBasicConstants.class.st

@@ -99,6 +99,7 @@ VMBasicConstants class >> namesDefinedAtCompileTime [
 	 will be emitted within #if defined(ANameDefinedAtCompileTime)...#endif."
 	^#(	VMBIGENDIAN
 		IMMUTABILITY
+		FEATURE_JIT_SIMD


It would be nice to move this VMBasicConstants class >> namesDefinedAtCompileTime somewhere else, it looks like a strange dependency.

guillep · 2025-04-30T07:36:22Z

smalltalksrc/VMMaker/CogX64Compiler.class.st

-{ #category : 'testing' }
-CogX64Compiler >> checkIs32bit: offset [
-
-	(offset between: -2147483648 and: 2147483647) ifFalse: [
-		self error: 'Cannot jump to distances larger than 32 bits' ]
-]
-


This method has just been reordered by tonel...

PalumboN

Niceeee 🪂 🧨

PalumboN · 2025-04-30T07:54:30Z

CMakeLists.txt

+option(VERBOSE_BUILD			"Verbose Build"														OFF)
+option(FEATURE_FFI				"Enable FFI"														ON)
+option(FEATURE_THREADED_FFI		"Enable Threaded (running in another thread) FFI"					ON)
+option(FEATURE_MESSAGE_COUNT	"Enable the option to count messages, only valid for StackVM"		OFF)
+option(FEATURE_NETWORK			"Enable network and sockets"										ON)
+option(FEATURE_JIT_SIMD			"Use SIMD support in JIT compilation when available"				ON)
+option(FEATURE_LIB_SDL2			"Build SDL2 support"												ON)
+option(FEATURE_LIB_CAIRO		"Build Cairo support"												ON)
+option(FEATURE_LIB_FREETYPE2	"Build freetype2 support"											ON)
+option(FEATURE_LIB_GIT2			"Build LibGit2 support"												ON)
+option(FEATURE_LIB_PTHREADW32	"Windows only, link to win32 version of pthread"					OFF)
+option(GENERATE_VMMAKER			"If it generates the VMMaker image"									ON)
+option(GENERATE_SOURCES			"If it generates the C sources"										ON)
+option(ALWAYS_INTERACTIVE		"Be interactive by default"											OFF)
+option(BUILD_BUNDLE				"Builds a bundle with all dependencies"								ON)
+option(FEATURE_COMPILE_GNUISATION
+								"Use gcc gnu extensions to compile the VM"							ON)
+option(FEATURE_COMPILE_INLINE_MEMORY_ACCESSORS
+								"Use inline memory accessors instead of macros"						ON)
+option(PHARO_DEPENDENCIES_PREFER_DOWNLOAD_BINARIES
+								"Prefer downloading dependencies"									OFF)
+option(PHARO_VM_IN_WORKER_THREAD
+								"Run the VM in a thread different that the main"					ON)
+option(DEPENDENCIES_FORCE_BUILD
+								"Force build libraries"												OFF)
+option(BUILD_WITH_GRAPHVIZ
+								"Generate dependency graphs"										ON)
+option(VERSION_UPDATE_FROM_GIT
+								"Extract version information from git tags. Default to true. Follow vX.Y.Z-suffix" ON)


Did you formatted or unformatted the code 😆

PalumboN · 2025-04-30T08:03:41Z

There are related failing tests:

VM Unit Tests / MacOSX64.VMMakerTests.VMJitVectorMethodTest.testJitCompiledFloat32VectorAddition(#ISA->#X64 #wordSize->8 #useComposedImageFormat->true) (from VMMakerTests)

Error
VM built without SIMD support
StackToRegisterMappingCogit(Object)>>error:
[ self error: 'VM built without SIMD support' ] in StackToRegisterMappingCogit>>genMappedInlinePrimitive:
False>>ifTrue:ifFalse:
StackToRegisterMappingCogit(SlangClass)>>cppIf:ifTrue:ifFalse:
StackToRegisterMappingCogit>>genMappedInlinePrimitive:
StackToRegisterMappingCogit>>genCallMappedInlinedPrimitive
StackToRegisterMappingCogit>>compileAbstractInstructionsFrom:through:
StackToRegisterMappingCogit(Cogit)>>compileMethodBody
StackToRegisterMappingCogit(Cogit)>>compileEntireMethod
StackToRegisterMappingCogit>>compileEntireMethod
StackToRegisterMappingCogit(Cogit)>>compileCogMethod:
StackToRegisterMappingCogit>>compileCogMethod:
StackToRegisterMappingCogit(Cogit)>>cog:selector:
VMJitVectorMethodTest(VMSimpleStackBasedCogitAbstractTest)>>jitMethod:selector:
VMJitVectorMethodTest(VMSimpleStackBasedCogitAbstractTest)>>jitMethod:
VMJitVectorMethodTest>>testJitCompiledFloat32VectorAddition
VMJitVectorMethodTest(TestCase)>>performTest

Add FEATURE_JIT_SIMD option

25b1903

- Make JIT SIMD optional with <option: #FEATURE_JIT_SIMD> - Add option FEATURE_JIT_SIMD to CMakeLists.txt - Add FEATURE_JIT_SIMD as a compile time option

guillep commented Apr 30, 2025

View reviewed changes

PalumboN approved these changes Apr 30, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add FEATURE_JIT_SIMD option #966

Add FEATURE_JIT_SIMD option #966

Uh oh!

guillep commented Apr 30, 2025

Uh oh!

guillep Apr 30, 2025

Uh oh!

PalumboN Apr 30, 2025

Uh oh!

guillep Apr 30, 2025

Uh oh!

guillep Apr 30, 2025

Uh oh!

guillep Apr 30, 2025

Uh oh!

PalumboN left a comment

Uh oh!

PalumboN Apr 30, 2025

Uh oh!

PalumboN commented Apr 30, 2025

Uh oh!

Uh oh!

Add FEATURE_JIT_SIMD option #966

Are you sure you want to change the base?

Add FEATURE_JIT_SIMD option #966

Uh oh!

Conversation

guillep commented Apr 30, 2025

Uh oh!

guillep Apr 30, 2025

Choose a reason for hiding this comment

Uh oh!

PalumboN Apr 30, 2025

Choose a reason for hiding this comment

Uh oh!

guillep Apr 30, 2025

Choose a reason for hiding this comment

Uh oh!

guillep Apr 30, 2025

Choose a reason for hiding this comment

Uh oh!

guillep Apr 30, 2025

Choose a reason for hiding this comment

Uh oh!

PalumboN left a comment

Choose a reason for hiding this comment

Uh oh!

PalumboN Apr 30, 2025

Choose a reason for hiding this comment

Uh oh!

PalumboN commented Apr 30, 2025

Uh oh!

Uh oh!