Add PHPStan updates #1
Merged
+78
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TysonAndre
reviewed
Jul 23, 2018
FunctionSignatureMap.php
Outdated
| @@ -9943,6 +9943,7 @@ | |||
| 'simplexml_load_file' => ['SimpleXMLElement|false', 'filename'=>'string', 'class_name='=>'string', 'options='=>'int', 'ns='=>'string', 'is_prefix='=>'bool'], | |||
| 'simplexml_load_string' => ['SimpleXMLElement|false', 'data'=>'string', 'class_name='=>'string', 'options='=>'int', 'ns='=>'string', 'is_prefix='=>'bool'], | |||
| 'SimpleXMLElement::__construct' => ['void', 'data'=>'string', 'options='=>'int', 'data_is_url='=>'bool', 'ns='=>'string', 'is_prefix='=>'bool'], | |||
| 'SimpleXMLElement::__get' => ['SimpleXMLElement', 'name'=>'string'], | |||
There was a problem hiding this comment.
This implements magic getters internally, but not through __get(). DynamicPropertyMap is what Phan uses to keep track of this type of edge case.
php > $x = new SimpleXMLElement('<b>x</b>');
php > $x->__get('b');
Warning: Uncaught Error: Call to undefined method SimpleXMLElement::__get() in php shell code:1
Stack trace:
#0 {main}
thrown in php shell code on line 1
php > var_export($x->b);
SimpleXMLElement::__set_state(array(
))
The rest of the changes look good
There was a problem hiding this comment.
Just removed that line
TysonAndre
reviewed
Jul 23, 2018
| @@ -9859,7 +9859,7 @@ | |||
| 'SessionUpdateTimestampHandler::validateId' => ['char', 'id'=>'string'], | |||
| 'SessionUpdateTimestampHandlerInterface::updateTimestamp' => ['bool', 'key'=>'string', 'val'=>'string'], | |||
| 'SessionUpdateTimestampHandlerInterface::validateId' => ['bool', 'key'=>'string'], | |||
| 'set_error_handler' => ['?string', 'error_handler'=>'null|callable(int,string,string,int,array):bool|callable(int,string,string,int):bool|callable(int,string,string):bool|callable(int,string):bool', 'error_types='=>'int'], | |||
| 'set_error_handler' => ['?callable', 'error_handler'=>'null|callable(int,string,string=,int=,array=):bool', 'error_types='=>'int'], | |||
There was a problem hiding this comment.
I overlooked the changes to the parameter union type - Those will need to be changed due to differences in Phan/Psalm's casting rules for callables, as discussed earlier.
The change to the return type makes sense.
There was a problem hiding this comment.
The fix was committed to master.
TysonAndre
added a commit
to phan/phan
that referenced
this pull request
Jul 23, 2018
Syncing changes from phpstan in phan/PHPSignatures#1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.