-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch sample import activities #971
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Just one comment about changing the key name which will require you to update wherever the key is used.
app/components/activities/projects/sample_activity_component.html.erb
Outdated
Show resolved
Hide resolved
app/components/activities/groups/sample_activity_component.html.erb
Outdated
Show resolved
Hide resolved
0231518
to
a6f7858
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more changes but looking good
app/components/activities/projects/sample_activity_component.html.erb
Outdated
Show resolved
Hide resolved
Code Metrics Report
Code coverage of files in pull request scope (98.1%)Reported by octocov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
What does this PR do and why?
Describe in detail what your merge request does and why.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other pull requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
test/fixtures/files/batch_sample_import_with_metadata_valid.csv
, edit the project_puid values to match the project we are importing to.Then repeat the above but with a group for the namespace, and verify that activities were made for both the project and the group samples were added to.
PR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.