-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deps: Rails 8 #959
Deps: Rails 8 #959
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…o be compatible for devcontainer
…EN/NOTIFY and CRON
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me and works as expected. Tested it out with local storage, and with azurite (minus the workflow executions as sapporo nextflow doesn't recognize azurite)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Tested a bunch of graphql queries/mutations as well as web ui functionality and everything seems to be working as expected.
Please update the schema files db/schema.rb
and db/jobs_schema.rb
which should have been updated to schema 8.0
and have enable_extension "pg_catalog.plpgsql"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I've ran |
Code Metrics Report
Reported by octocov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
What does this PR do and why?
Describe in detail what your merge request does and why.
This PR upgrades our rails dependency to 8.0.1.
A few notables changes:
*DATABASE_URL
env variables fromconfig/database.yml
*DATABASE_URL
env variables (https://github.com/rails/rails/blob/ccf59d6d3a1d106e6ac44342fe2e8f89b61bc992/activerecord/lib/active_record/database_configurations.rb#L305)identifier
inrubyLsp.rubyVersionManager
to auto, so that a developer doesn't need asdf if they don't want to use it (e.g. to support devcontainers better in the future)bin/docker-entrypoint
updated to support using thruster (no change to use it yet though)bin/setup
which is necessary for devcontainersScreenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other pull requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
PR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.