Added paging support and pageSize option and improved data parsing an… #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d array handling.
|
Looks fine to me, the commit is attributed to the original author and the documented license in the Segfault-Inc project is the same as here, so, sure. 👍 |
|
nice. this makes it into 3.2
…On Thu, Oct 9, 2025 at 10:13 PM Mathieu Fenniak ***@***.***> wrote:
*mfenniak* left a comment (pgsql-io/multicorn2#88)
<#88 (comment)>
Looks fine to me, the commit is attributed to the original author and the
documented license in the Segfault-Inc project is the same as here, so,
sure. 👍
—
Reply to this email directly, view it on GitHub
<#88 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMWOHVJIBW4DVOXUAU4RST3W4I2XAVCNFSM6AAAAACIC5BDHGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGOBYGA2DGMRYGA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Added paging support and pageSize option and improved data parsing and array handling."
copied from Segfault-Inc/Multicorn#240 . Solves #87 .
I have successfully tested: > 1000 records are now received from ldap (even without setting pagesize).