Correct the fix to trim spaces from gnuplot function
#1412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yukai Chou <[email protected]>
Signed-off-by: Yukai Chou <[email protected]>
Signed-off-by: Yukai Chou <[email protected]>
This was referenced Aug 28, 2025
Signed-off-by: Yukai Chou <[email protected]>
|
#1399 is already released, so we need a hotfix, right? |
hmenke
approved these changes
Aug 29, 2025
hmenke
reviewed
Aug 29, 2025
| \def\pgfutil@shellescape@lua@eightseven#1{% | ||
| \pgfutil@directlua{os.execute("\pgfutil@luaescapestring{#1}")}% | ||
| \pgfutil@directlua{% | ||
| local write_nl = texio.write_nl |
There was a problem hiding this comment.
We will only ever call texio.write_nl once, so we don't gain anything from the local binding, but you can leave it. Just wanted to point that out.
Unfortunately, yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Correct the fix for #1397, see analysis #1399 (review). The previous fix was #1399.
Fixes #1397.
Checklist
Please signoff your commits to explicitly state your agreement to the Developer Certificate of Origin. If that is not possible you may check the boxes below instead: