- 
                Notifications
    You must be signed in to change notification settings 
- Fork 114
Support & in matrices without catcode change #1081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            gabor-braun
  wants to merge
  19
  commits into
  pgf-tikz:master
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
gabor-braun:matrix-ampersand
  
      
      
   
  
    
  
  
  
 
  
      
    base: master
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
  
     Open
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            19 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      2407ff0
              
                Fix "\matrix{a \\ b &[between origins] c};"
              
              
                gabor-braun 85f842a
              
                Break up \pgf@matrix@endcell for future changes.
              
              
                gabor-braun 3418205
              
                pgfmatrix: Smuggle row and column separation out of all cells.
              
              
                gabor-braun 70a400a
              
                pgfmatrix: delay handling column separation.
              
              
                gabor-braun 11f8ab9
              
                Remove \ifpgf@matrix@last@cell@in@row.
              
              
                gabor-braun a7ab036
              
                Remove one \pgf@matrix@maxxN initialization, no longer needed.
              
              
                gabor-braun 739b4a5
              
                pgfmatrix: remove unused \pgf@matrix@eom@found.
              
              
                gabor-braun 59fe51c
              
                Simplify detecting empty cell.
              
              
                gabor-braun 3c127e2
              
                pgfmatrix: Care for & when parsing optional arguments.
              
              
                gabor-braun b4c3b7c
              
                Remove a no longer needed global assignment.
              
              
                gabor-braun ef27e67
              
                pgfmatrix: support & as cell separator, simplify last cell test.
              
              
                gabor-braun 9181d20
              
                No longer make & active in TikZ matrices.
              
              
                gabor-braun d660a5a
              
                pgfmatrix: Remove internal variable \pgf@matrix@paddingskip.
              
              
                gabor-braun d4ebe22
              
                pgfmatrix: Simplify by removing \ifpgf@matrix@empty@cell.
              
              
                gabor-braun ab2bedf
              
                Recombine \pgf@matrix@endcell.
              
              
                gabor-braun 2a365ea
              
                \pgfmatrix: deduplicate halign header.
              
              
                gabor-braun aea0349
              
                \pgfmatrix: slightly simplify adding row separation.
              
              
                gabor-braun fbcaa39
              
                \pgfmatrix: Optimize out \pgf@matrix@column@sep@N.
              
              
                gabor-braun 10a77b1
              
                matrices: Add some tests for & as cell separator.
              
              
                gabor-braun File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now that the row is changed anyway, we can directly remove one of the remaining "double space" instances :)