cmd/seriesmeta: Add Unicode normalization for book IDs #111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_seriesmeta
trigger searches thecontent
table for a book with the same ID as the inserted one.It works fine with ASCII IDs (which are kinda file paths BTW). However, when calling
seriesmeta
on macOS with Unicode file names being involved, it doesn’t work. This happens because IDs atcontent
are NFC-normalized when macOS returns file paths as NFD-normalized strings. As an example (using Python):In other words, visually values might look the same but without the normalization the SQLite comparison will not work.