Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_remove_all_separators() works when no separator exists #171

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+3 −1
Open

_remove_all_separators() works when no separator exists #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cc1e13d
remove_separators() works when no separators exist
DanielRaapDev Feb 12, 2025
8e636cf
add changelog fragment for bugfix
DanielRaapDev Feb 13, 2025
52c428e
changelog list entry must be a string
DanielRaapDev Feb 13, 2025
b34f6d8
remove backtick escape in string as it is not part of yaml
DanielRaapDev Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/170_pfsense_interface_fix_remove_all_separators.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
bugfixes:
- "pfsense_interface - fixes removal of an interface with `state: absent`. _remove_all_separators() works when no separator exists for that interface. (https://github.com/pfsensible/core/issues/170)"
2 changes: 1 addition & 1 deletion plugins/module_utils/interface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ def _remove_all_rules(self, interface):
def _remove_all_separators(self, interface):
""" delete all interface separators """
todel = []
separators = self.pfsense.rules.find('separator')
separators = self.pfsense.rules.find('separator') or []
for interface_elt in separators:
if interface_elt.tag != interface:
continue
Expand Down
Loading