Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DHCP Server #140

Merged
merged 1 commit into from
Mar 15, 2025
Merged

DHCP Server #140

merged 1 commit into from
Mar 15, 2025

Conversation

davrosza
Copy link
Contributor

Changes made:

  1. Added new module: pfsensible_dhcp_server.py, to manage DHCP server settings
  2. Extended core utilities to support DHCP-specific operations
  3. Added unit tests for new DHCP functionality

opoplawski
opoplawski requested changes Jan 26, 2025
View reviewed changes
Copy link
Contributor

@opoplawski opoplawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! There are a number of CI fixes to make. Also, please add a changelog fragment.

@opoplawski opoplawski mentioned this pull request Feb 28, 2025
Open
@davrosza davrosza requested a review from opoplawski March 6, 2025 03:33
@opoplawski opoplawski changed the title DHCPD Server DHCP Server Mar 11, 2025
opoplawski
opoplawski requested changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@opoplawski opoplawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to rebase and squash down your commits as well. Thanks again.

@davrosza davrosza force-pushed the feature/dhcp-server branch from dc6c515 to f627703 Compare March 13, 2025 23:24
@davrosza
Copy link
Contributor Author

Changes incorporated, git history squashed and rebased. Let me know if there is anything else that should be changed

@davrosza davrosza requested a review from opoplawski March 13, 2025 23:41
opoplawski
opoplawski approved these changes Mar 15, 2025
View reviewed changes
Copy link
Contributor

@opoplawski opoplawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable for now. Thanks!

@opoplawski opoplawski merged commit aaede2f into pfsensible:master Mar 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opoplawski opoplawski opoplawski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davrosza @opoplawski