Update User module to create & bind certificate #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR. I'm not entirely sure I like the creation of a new |
|
We would also want a changelog fragment. |
opoplawski
force-pushed
the
feature/user_cert_direct
branch
from
4bd0bb2 to
1ab943d
Compare
|
And there are some CI tests to fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a User through the PFSense web interface you have the option to generate a certificate for that user.
The PR mimics that behavior while trying to reuse as much as possible the existing modules.
The approach I took is one of the many possible, I tried to stay as close as possible to the behavior of the web interface.