Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pfsense_ca): add certificate_key option #117

Closed
wants to merge 1 commit into from
Closed

fix(pfsense_ca): add certificate_key option #117

wants to merge 1 commit into from

Conversation

genofire
Copy link
Contributor

No description provided.

opoplawski
opoplawski requested changes Jan 26, 2025
View reviewed changes
Copy link
Contributor

@opoplawski opoplawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Please also add a changelog fragment.

plugins/modules/pfsense_ca.py
@@ -106,6 +112,7 @@
trust=dict(type='bool'),
randomserial=dict(type='bool'),
certificate=dict(type='str'),
certificate_key=dict(type='str'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to add no_log=True

@opoplawski
Copy link
Contributor

This was addressed separately with #157 and #166

@opoplawski opoplawski closed this Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opoplawski opoplawski opoplawski requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@genofire @opoplawski