enforce canonical encoding and MAX_SIZE in VarIntSerializer #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`core.serialize.VarIntSerializer` now checks for value bounds of deserialized compact size integer. If it enconters non-canonical encoding, or the size bigger than `MAX_SIZE` (0x02000000) it throws DeserializationValueBoundsError
Contributor
Author
|
the use of |
Owner
|
Yeah, writing py3-only code is fine now. Is there anything else you'd do if this pull-req was py3-only? |
Contributor
Author
No, this code was ported from python-bitcointx, which is py3-only from the start. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core.serialize.VarIntSerializernow checks for value bounds of deserializedcompact size integer. If it enconters non-canonical encoding, or the size
bigger than
MAX_SIZE(0x02000000) it throws DeserializationValueBoundsErrorI just noticed that
VarIntSerializer.stream_deserialize()is not in line with current Core'sReadCompactSize(). It does not check forMAX_SIZE(the check that was there from the start, I think), and it also does not check for the encodings to be canonical (if the encoding is of 3-byte length, it should not contain value less than 0xFD, etc) - the constraint added in 2013.This patch adds the checks and the new exception,
DeserializationValueBoundsError.Tests now do not try to validate non-canonical encodings, but check that non-canoncial encodings throw the appropriate exception.