Improve .toString(2) performance #178
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
Yaffle
reviewed
Apr 9, 2019
BigInteger.js
Outdated
|
|
||
| BigInteger.prototype.toString = function (radix, alphabet) { | ||
| if (radix === undefined) radix = 10; | ||
| if (radix === 2) return (this.sign ? "-" : "") + this.toArray(2).value.join(''); |
Collaborator
There was a problem hiding this comment.
what about the alphabet argument?
Author
There was a problem hiding this comment.
Ah, yes i did not consider that. I updated it to only apply the optimization if the alphabet parameter is not provided. That may be a bit hacky now, whatcha think?
Owner
|
Good point @Yaffle, that makes me realize that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.