-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PMM-13648 fix migration #3436
Open
BupycHuk
wants to merge
3
commits into
PMM-13629-fix-pmm-managed-npe-issue
Choose a base branch
from
PMM-13648-fix-migration
base: PMM-13629-fix-pmm-managed-npe-issue
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
PMM-13648 fix migration #3436
BupycHuk
wants to merge
3
commits into
PMM-13629-fix-pmm-managed-npe-issue
from
PMM-13648-fix-migration
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BupycHuk
requested review from
idoqo and
JiriCtvrtka
and removed request for
a team
January 8, 2025 09:40
idoqo
approved these changes
Jan 8, 2025
ademidoff
approved these changes
Jan 8, 2025
JiriCtvrtka
reviewed
Jan 8, 2025
Comment on lines
-1132
to
-1145
|
||
`UPDATE settings SET settings = jsonb_set(settings, '{encrypted_items}', | ||
'[ | ||
"pmm-managed.agents.username", | ||
"pmm-managed.agents.password", | ||
"pmm-managed.agents.agent_password", | ||
"pmm-managed.agents.aws_options", | ||
"pmm-managed.agents.azure_options", | ||
"pmm-managed.agents.mongo_options", | ||
"pmm-managed.agents.mysql_options", | ||
"pmm-managed.agents.postgresql_options" | ||
]'::jsonb | ||
) | ||
WHERE settings ? 'encrypted_items';`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this work when someone migrate from v3 beta?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't support upgrade from v3 beta
JiriCtvrtka
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-13648
Link to the Feature Build: SUBMODULES-3815
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: