Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-12287 Document removal of Integrated Alerting #3435

Open
wants to merge 5 commits into
base: RelNotes-3-0-0-GA
Choose a base branch
from

Conversation

ademidoff
Copy link
Member

@it-percona-cla
Copy link

it-percona-cla commented Jan 8, 2025

CLA assistant check
All committers have signed the CLA.

@@ -41,6 +41,7 @@ To use SMTP with a PMM Docker installation:
- `GF_SMTP_FROM_NAME`: Name to be used when sending out emails.

*NB: If you are using your Gmail’s SMTP credentials as shown above, you will have to generate an app password and fill it in as the value of your $GF_SMTP_PASSWORD variable.*

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the bullet point rendering.


!!! caution alert alert-warning "Important"
Time specified in mute timing must be in UTC and military format i.e. 14:00 not 2:00 PM.
Time specified in mute timing must be in UTC format, i.e. 14:00, not 2:00 PM.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Military is not a well-known term, so I removed it to avoid confusion.

@@ -13,5 +13,5 @@ Percona Alerting is powered by Grafana infrastructure. It leverages Grafana's ad
Depending on the datasources that you want to query, and the complexity of your required evaluation criteria, Percona Alerting enables you to create the following types of alerts:

- **Percona templated alerts**: alerts based on a set of Percona-supplied templates with common events and expressions for alerting.
If you need custom expressions on which to base your alert rules, you can also create your own templates.
If you want to use custom expressions in alert rules, you can create your own alert rule templates.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes it a bit more clear.

@@ -269,9 +269,10 @@ nav:
- Percona Alerting:
- alert/index.md
- alert/alert_rules.md
- alert/alert_notifications.md
Copy link
Member Author

@ademidoff ademidoff Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was rendering as None for such page is absent.

Screenshot 2025-01-08 at 12 03 55

@ademidoff ademidoff marked this pull request as ready for review January 8, 2025 09:07
@ademidoff ademidoff requested a review from a team as a code owner January 8, 2025 09:07
@ademidoff ademidoff requested a review from catalinaadam January 8, 2025 09:08
@ademidoff ademidoff requested a review from catalinaadam January 8, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants