PMM-12644 Remove the use of data container #3414
Open
+302
−1,761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* PMM-12566 Update env variables and support data container installations. * PMM-12566 Update env variables and support data container installations. * PMM-12566 Update env variables and support data container installations. * Apply suggestions from code review * PMM-12566 Start 3.0.0 beta by default. * PMM-12566 Fix check.
* PMM-7 typos check job. * PMM-7 Update main.yml to clean up fetch-depth comment Removed an unnecessary comment in the GitHub Actions workflow file. This change simplifies the configuration by eliminating redundant information without affecting functionality. * PMM-7 Update typos action to include markdown files Extended the typos action configuration to check `.md` files for spelling errors. This ensures consistency and correctness across documentation files in the repository. * PMM-7 Fix typos across documentation and workflows Corrected multiple spelling mistakes in markdown files and updated the workflow file to check spellings in all .md files. This improves documentation clarity and ensures consistency in future contributions. * PMM-7 Try to fix typos job to include documentations folder * PMM-7 Try to fix typos job to include documentations folder * PMM-7 Fix typos across documentation and add typos config. Corrected a range of spelling mistakes in documentation files to improve clarity and professionalism. Added `.typos.toml` to configure typo checks and modified workflow to include documentation in typo scanning.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #3414 +/- ##
==========================================
- Coverage 43.53% 43.53% -0.01%
==========================================
Files 366 366
Lines 44238 44238
==========================================
- Hits 19261 19259 -2
- Misses 23289 23291 +2
Partials 1688 1688
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ademidoff
requested review from
BupycHuk,
idoqo and
JiriCtvrtka
and removed request for
a team
JiriCtvrtka
approved these changes
Dec 27, 2024
* PMM-13483 Remove pmm-update.spec * PMM-13483 Remove pmm-update package * PMM-13483 Use same syntax * PMM-13483 Rename pmm-update.log to pmm-init.log * PMM-13483 Don't stop Grafana * PMM-13483 Reorder the logs in the test * PMM-13483 Start grafana only when it was successfully stopped * PMM-13483 Rename pmm-update to pmm-init * PMM-13483 Temp fix for grafana restart * PMM-13483 Clean up .gitignore * PMM-13483 Remove redundant when condition
idoqo
approved these changes
Jan 6, 2025
Comment on lines
+42
to
+44
| ## Migrate from data container to host directory | ||
|
|
||
| To migrate your PMM from data container to host directory or volume run the following command: | ||
| To migrate your PMM from data container to host directory, run the following command: |
There was a problem hiding this comment.
Is data container still the right term here?
There was a problem hiding this comment.
IMO yes, it still is the right term.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-12644
https://pmm-doc-3-pr-3414.onrender.com/install-pmm/install-pmm-server/baremetal/docker/index.html
https://pmm-doc-3-pr-3414.onrender.com/pmm-upgrade/migrating_from_pmm_2.html