Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-13629 fix pmm managed npe issue #3404

Open
wants to merge 8 commits into
base: v3
Choose a base branch
from

PMM-13629 Remove encryption.key.

17a0dea
Select commit
Loading
Failed to load commit list.
Open

PMM-13629 fix pmm managed npe issue #3404

PMM-13629 Remove encryption.key.
17a0dea
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 6, 2025 in 0s

43.52% (-0.02%) compared to ee9720f

View this Pull Request on Codecov

43.52% (-0.02%) compared to ee9720f

Details

Codecov Report

Attention: Patch coverage is 74.50980% with 39 lines in your changes missing coverage. Please review.

Project coverage is 43.52%. Comparing base (ee9720f) to head (17a0dea).

Files with missing lines Patch % Lines
managed/models/agent_model.go 77.35% 12 Missing ⚠️
managed/services/agents/agents.go 53.84% 3 Missing and 3 partials ⚠️
managed/services/inventory/agents.go 58.33% 5 Missing ⚠️
managed/services/management/mysql.go 0.00% 3 Missing ⚠️
managed/services/management/postgresql.go 0.00% 3 Missing ⚠️
managed/services/management/agent.go 91.30% 2 Missing ⚠️
managed/services/management/azure_database.go 0.00% 2 Missing ⚠️
managed/services/management/mongodb.go 0.00% 2 Missing ⚠️
managed/models/agent_helpers.go 95.45% 1 Missing ⚠️
managed/services/agents/handler.go 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files 
@@            Coverage Diff             @@
##               v3    #3404      +/-   ##
==========================================
- Coverage   43.54%   43.52%   -0.02%     
==========================================
  Files         366      366              
  Lines       44237    44243       +6     
==========================================
- Hits        19261    19258       -3     
- Misses      23288    23303      +15     
+ Partials     1688     1682       -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov