Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-13483 Refactor pmm-update #3317

Merged
merged 16 commits into from
Dec 28, 2024
Merged

PMM-13483 Refactor pmm-update #3317

merged 16 commits into from
Dec 28, 2024

Conversation

ademidoff
Copy link
Member

@ademidoff ademidoff commented Nov 18, 2024

PMM-13483

Link to the Feature Build: SUBMODULES-3775

Note: pmm-managed tests will stop failing once we merge this PR to v3.

@ademidoff ademidoff changed the base branch from main to v3 November 18, 2024 13:30
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.51%. Comparing base (b7885f1) to head (43f2330).
Report is 1 commits behind head on v3.

Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #3317      +/-   ##
==========================================
- Coverage   43.57%   43.51%   -0.06%     
==========================================
  Files         366      366              
  Lines       44238    44168      -70     
==========================================
- Hits        19275    19219      -56     
+ Misses      23275    23264      -11     
+ Partials     1688     1685       -3     
Flag Coverage Δ
admin 11.51% <ø> (ø)
agent 51.83% <ø> (-0.13%) ⬇️
vmproxy 68.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ademidoff ademidoff marked this pull request as ready for review November 20, 2024 11:57
@ademidoff ademidoff requested review from idoqo and JiriCtvrtka and removed request for a team November 20, 2024 11:57
@ademidoff ademidoff changed the title PMM-13483 Refactor pmm update PMM-13483 Refactor pmm-update Nov 20, 2024
@JiriCtvrtka
Copy link
Contributor

@ademidoff could you update test in managed to match new name?

@ademidoff
Copy link
Member Author

@ademidoff could you update test in managed to match new name?

Sure, that's what I did - it expects pmm-init.log, but it gets pmm-update-perform-init.log, which is the old name coming from 3-dev-latest image. As I mentioned above, once we merge this PR, the error will be gone.

build/ansible/roles/initialization/tasks/main.yml Outdated Show resolved Hide resolved
@@ -1,65 +0,0 @@
# Update of PMM Server
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably we need analog of this doc for new update process.

@ademidoff ademidoff merged commit ee9720f into v3 Dec 28, 2024
30 of 32 checks passed
@ademidoff ademidoff deleted the PMM-13483-refactor-pmm-update branch December 28, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants